Skip to content

chore: base template align node version with vite 7 #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

btea
Copy link
Collaborator

@btea btea commented Jul 1, 2025

Description

sync #774

@btea btea requested a review from cexbrayat July 7, 2025 05:33
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but I'll let @haoqunjiang decide if we want to maintain this in sync

@haoqunjiang
Copy link
Member

I think npm install and similar commands would already throw on unsupported Node versions when the package manager tries to install vite? If so, we don't need to add this to the template explicitly. It doesn't add any new information to the project, yet it may become a maintenance burden in the future.

@btea
Copy link
Collaborator Author

btea commented Jul 13, 2025

I now use Node 18 to run pnpm create vue to create a project and execute pnpm i, and no errors or prompts appear. It is not until pnpm dev is executed that the error appears.

Therefore, if the required node version information is added to package.json, the user can be informed more clearly of the reason.

In fact, after Vite released 7, many people encountered this problem and raised issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants